This repository was archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] add value to disable tests#1116
Merged
jmlrt merged 3 commits intoelastic:masterfrom Jul 7, 2021
Merged
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
nflaig
force-pushed
the
feature/disable_tests
branch
from
c840c9d to
04c3a5b
Compare
jmlrt
reviewed
Apr 12, 2021
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Thanks for this PR, can you update the README with this new value?
nflaig
force-pushed
the
feature/disable_tests
branch
from
04c3a5b to
a6490b8
Compare
Signed-off-by: nflaig <nflaig@protonmail.com>
nflaig
force-pushed
the
feature/disable_tests
branch
from
a6490b8 to
3a87fe8
Compare
Contributor
Author
|
@jmlrt Thanks again for the review! I updated the README with the new value |
Contributor
Author
|
@jmlrt any update on this? Let me know if I should apply further changes |
jmlrt
previously approved these changes
Jul 7, 2021
Member
jmlrt
left a comment
jmlrt
left a comment
There was a problem hiding this comment.
Fixed the conflict. Change LGTM. As a minor improvement, I think it could be great to also add a {{- if .Values.tests.enabled -}} condition to not print test command when the test is disabled.
helm-charts/elasticsearch/templates/NOTES.txt
Lines 3 to 4 in 0e5a168
… is disabled Signed-off-by: nflaig <nflaig@protonmail.com>
Member
|
jenkins test this please |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 13, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
jmlrt
added a commit
that referenced
this pull request
Sep 21, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
jmlrt
added
v7.14.2
backport
backported
need-backport
and removed
backported
backport
labels
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 22, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Sep 22, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Sep 22, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
jmlrt
added a commit
that referenced
this pull request
Sep 22, 2021
* [elasticsearch] add value to disable tests Signed-off-by: nflaig <nflaig@protonmail.com> * [elasticsearch] add condition to not print test command when the test is disabled Signed-off-by: nflaig <nflaig@protonmail.com> Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be possible to disable the tests of the chart. This is especially important if the chart is used as a subchart which means the test are also executed if you run
helm test. For some users it might not be desirable to run the test provided by the elastic helm chart, the value gives the user of the chart the option to configure this.${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml